From: | "Florian G(dot) Pflug" <fgp(at)phlo(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Jacky Leng <lengjianquan(at)163(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Why copy_relation_data only use wal whenWALarchivingis enabled |
Date: | 2007-10-18 16:03:56 |
Message-ID: | 471783EC.9040200@phlo.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> "Florian G. Pflug" <fgp(at)phlo(dot)org> writes:
>> What is the argument against making relfilenodes globally unique by adding
>> the xid and epoch of the creating transaction to the filename?
>
> 1. Zero chance of ever backpatching. (I know I said I wasn't excited about
> that, but it's still a strike against a proposed fix.)
>
> 2. Adds new fields to RelFileNode, which will be a major code change, and
> possibly a noticeable performance hit (bigger hashtable keys).
>
> 3. Adds new columns to pg_class, which is a real PITA ...
>
> 4. Breaks oid2name and all similar code that knows about relfilenode.
Ah, Ok. I was under the impression that relfilenode in pg_class is a string of
some kind. In that case only GetNewRelFileNode would have needed patching...
But that is obviously not the case, as I realized now :-(
Thanks for setting me straight ;-)
regards, Florian Pflug
From | Date | Subject | |
---|---|---|---|
Next Message | Gregory Stark | 2007-10-18 16:07:20 | Re: ts_rewrite aggregate API seems mighty ugly |
Previous Message | Decibel! | 2007-10-18 15:56:39 | Re: max_prepared_transactions default ... why 5? |
From | Date | Subject | |
---|---|---|---|
Next Message | Scott Marlowe | 2007-10-18 16:05:35 | Re: Crosstab Problems |
Previous Message | Tom Lane | 2007-10-18 15:47:37 | Re: Crosstab Problems |