| From: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | "Marek Lewczuk" <newsy(at)lewczuk(dot)com> |
| Cc: | "pgsql-jdbc" <pgsql-jdbc(at)postgresql(dot)org> |
| Subject: | Re: AbstractJdbc2Array - another patch |
| Date: | 2007-10-11 11:00:50 |
| Message-ID: | 470E0262.2050704@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
Marek Lewczuk wrote:
> in the attachment you can find AbstractJdbc2Array with small patch
> (empty array was wrongly interpreted). Please test it and if possible
> add to cvs.
There seems to be a lot of unrelated stylistic changes, whitespace
changes, renaming of fields etc. in that new file. That makes it hard to
see what the problem is that it's fixing, and what was done to fix it.
Please make just the changes required to fix the problem, and if you
want to propose any other changes, send them as separate patches.
Also, please send patches in a "cvs diff -c" format, instead of sending
the whole file.
A small test case demonstrating the problem would also be very nice, to
help with the testing.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brian Oki (boki) | 2007-10-11 16:35:37 | Support for distributed transactions |
| Previous Message | Marek Lewczuk | 2007-10-11 08:59:19 | AbstractJdbc2Array - another patch |