Re: Skytools committed without hackers discussion/review

From: Shane Ambler <pgsql(at)Sheeky(dot)Biz>
To: Devrim GÜNDÜZ <devrim(at)CommandPrompt(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Michael Glaesemann <grzm(at)seespotcode(dot)net>, "Joshua D(dot) Drake" <jd(at)CommandPrompt(dot)com>, Jan Wieck <JanWieck(at)Yahoo(dot)com>
Subject: Re: Skytools committed without hackers discussion/review
Date: 2007-10-10 04:05:00
Message-ID: 470C4F6C.90504@Sheeky.Biz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Devrim GÜNDÜZ wrote:
> Hi,
>
> On Tue, 2007-10-09 at 16:50 -0700, Joshua D. Drake wrote:
>> IMO, the patch is reverted, and submitted for 8.4 or pgfoundry.
>
> You know, txid was discussed in Slony-I + Skytools lists for a
> reasonably long time, and Tom also commented in that thread. I agree
> that we broke the policy this time, but this does not mean the end of
> the world.

If it has been discussed and planned for so long then it should have
been considered for inclusion earlier, not just slipped under the radar.
Even if at feature freeze it wasn't ready it could have been discussed
whether it could be added after feature freeze if it reached an
acceptable standard.

If Slony or Skytools need this for a new feature in their x.y release
then it can be a patch that is included with their release or be a
prerequisite for their version x.y and detailed in their install steps.

Then they can discuss getting the change accepted into core or contrib
for the next pg release.

just my .02c

--

Shane Ambler
pgSQL(at)Sheeky(dot)Biz

Get Sheeky @ http://Sheeky.Biz

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Euler Taveira de Oliveira 2007-10-10 04:14:56 Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as
Previous Message Devrim GÜNDÜZ 2007-10-10 03:59:46 Re: Skytools committed without hackers discussion/review

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira de Oliveira 2007-10-10 04:14:56 Re: [COMMITTERS] pgsql: Added the Skytools extended transaction ID module to contrib as
Previous Message Devrim GÜNDÜZ 2007-10-10 03:59:46 Re: Skytools committed without hackers discussion/review