Re: pg_dump: Remove "blob" terminology

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump: Remove "blob" terminology
Date: 2022-12-02 07:09:46
Message-ID: 46f79a73-fd07-6dac-fbb0-c2582b667879@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 30.11.22 09:07, Daniel Gustafsson wrote:
> The commit message contains a typo: functinos

fixed

> * called for both BLOB and TABLE data; it is the responsibility of
> - * the format to manage each kind of data using StartBlob/StartData.
> + * the format to manage each kind of data using StartLO/StartData.
>
> Should BLOB be changed to BLOBS here (and in similar comments) to make it
> clearer that it refers to the archive entry and the concept of a binary large
> object in general?

I changed this one and went through it again to tidy it up a bit more.
(There are both "BLOB" and "BLOBS" archive entries, so both forms still
exist in the code now.)

> Theres an additional mention in src/test/modules/test_pg_dump/t/001_base.pl:
>
> # Tests which are considered 'full' dumps by pg_dump, but there.
> # are flags used to exclude specific items (ACLs, blobs, etc).

fixed

I also put back the old long options forms in the documentation and help
but marked them deprecated.

Attachment Content-Type Size
v2-0001-pg_dump-Remove-blob-terminology.patch text/plain 65.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-12-02 07:20:46 Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures
Previous Message Amit Kapila 2022-12-02 07:05:27 Re: Time delayed LR (WAS Re: logical replication restrictions)