Re: Rename latestCompletedXid to latestCommittedXid

From: "Florian G(dot) Pflug" <fgp(at)phlo(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Rename latestCompletedXid to latestCommittedXid
Date: 2007-09-12 15:18:06
Message-ID: 46E8032E.6020807@phlo.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> "Florian G. Pflug" <fgp(at)phlo(dot)org> writes:
>> Per my post to the hackers list, here is a patch that renamed
>> latestCompletedXid to latestCommittedXid, and updates it only
>> on commits.
>
> This is wrong --- it will break early detection of aborted
> subtransactions.

I don't see how - TransactionIdIsInProgress doesn't even touch
latestCompletedXid. And I didn't mess with XidCacheRemoveRunningXids,
other than removing the latestCompletedXid updating.

Am I missing something?

greetings, Florian Pflug

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-09-12 15:31:39 Re: Rename latestCompletedXid to latestCommittedXid
Previous Message Tom Lane 2007-09-12 15:04:20 Re: Rename latestCompletedXid to latestCommittedXid