Re: Yet more tsearch refactoring

From: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
To: "Teodor Sigaev" <teodor(at)sigaev(dot)ru>
Cc: "Patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Yet more tsearch refactoring
Date: 2007-09-10 21:59:44
Message-ID: 46E5BE50.70803@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Teodor Sigaev wrote:
> Heikki Linnakangas wrote:
>> * Defined new struct WordEntryPosVector that holds a uint16 length and a
>> variable size array of WordEntries. This replaces the previous
>> convention of a variable size uint16 array, with the first element
>> implying the length. WordEntryPosVector has the same layout in memory,
>> but is more readable in source code. The POSDATAPTR and POSDATALEN
>> macros are still used, though it would now be more readable to access
>> the fields in WordEntryPosVector directly.
>
> Did you check it on 64-bit boxes with strict alignment? I remember that
> was a headache for me.

No, I didn't. But I don't see how it would make a difference, the
resulting memory layout is the same AFAICS.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tatsuo Ishii 2007-09-11 01:14:40 Re: invalidly encoded strings
Previous Message Teodor Sigaev 2007-09-10 20:54:54 Re: Yet more tsearch refactoring