| From: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: tsearch2 patch status report |
| Date: | 2007-08-21 17:05:40 |
| Message-ID: | 46CB1B64.10205@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
>> The memory management of the init functions looks weird. In spell.c,
>> there's this piece of code:
>
> I saw that and didn't care for it much, but didn't look into exactly
> what would be needed to get rid of it. (I did clean up another place
> that had a *global* magic context pointer ... that looked like trouble
> waiting to happen.) If you make the outside caller create the context,
> does it need to be passed explicitly or can it just be
> CurrentMemoryContext when they are called?
I believe CurrentMemoryContext would work just fine. I'll put together a
patch.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2007-08-21 17:12:55 | Re: A couple of tsearch loose ends |
| Previous Message | Cédric Villemain | 2007-08-21 17:03:13 | Re: tsearch2 patch status report |