From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Beta 2 Wednesday? |
Date: | 2007-07-30 08:57:52 |
Message-ID: | 46ADA810.5070301@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Guillaume Lelarge wrote:
> Dave Page a écrit :
>> Guillaume Lelarge wrote:
>> [...]
>>> OK, I think I've found a fix to Pavel's issue. To check cbLanguage, we
>>> use GetCurrentSelection. When I try to change an already defined
>>> function, GetCurrentSelection always returns -1 which is an invalid
>>> value. If I use GetGuessedSelection (with every other changes needed to
>>> use ctlComboBox instead of wxComboBox), it works great. I'm not sure
>>> this is the right way to fix this, so here is the patch.
>>>
>>> As always, comments welcomed.
>> Hmm, sounds like it might be platform specific issue, similar to (but
>> not the same) one Stefan fixed for me in wxMac before 2.8 was released.
>>
>> What OS and version of wxWidgets is this?
>>
>
> Kubuntu 7.04 (linux 2.6.20).
> wxWidgets 2.8.4 (kubuntu's package).
>
> I don't know for Pavel.
>
>> I have no problem with the patch, so if this is reproducable with the
>> latest wx version, please go ahead and apply.
>>
>
> If you're still OK, I will commit it today.
Please do.
Thanks, Dave
From | Date | Subject | |
---|---|---|---|
Next Message | svn | 2007-07-30 09:06:11 | SVN Commit by guillaume: r6510 - in trunk/pgadmin3/pgadmin: dlg ui |
Previous Message | Guillaume Lelarge | 2007-07-30 08:45:55 | Re: Beta 2 Wednesday? |