Re: write_pipe_chunks patch messes up early error message output

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: write_pipe_chunks patch messes up early error message output
Date: 2007-07-19 19:16:46
Message-ID: 469FB89E.7060902@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> Anyway, I think the attached patch will do what we need.
>>
>
> I think you could leave Redirect_stderr out of the elog.c tests
> entirely, since redirection_done can never become set without it.
>
> Also, you introduced a bug: pgwin32_is_service is a function no?
> Needs invocation parens.
>
> Otherwise looks reasonable.
>
>
>

Thanks. Applied with those fixes, back as far as 8.0.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joshua D. Drake 2007-07-19 20:28:47 Re: 8.3 Release Schedule
Previous Message Dave Page 2007-07-19 19:01:14 Re: 8.3 Release Schedule