| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Jacob Champion <jchampion(at)timescale(dot)com>, heath(dot)lord(at)crunchydata(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection |
| Date: | 2022-09-29 21:58:11 |
| Message-ID: | 467714.1664488691@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 29 Sep 2022, at 23:08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> A definition that'd be consistent with what we just agreed to for
>> PQsslAttribute is:
>> PQsslAttributeNames(NULL): the attributes for the default SSL library,
>> or an empty list if there is none.
>> PQsslAttributeNames(conn): the attributes for the SSL library in use
>> on this connection, or an empty list if not encrypted.
> I think that makes sense, it keeps the API consistent.
So more or less as attached, then.
Since this is mostly about future-proofing, I'd personally be content
to put it in HEAD. Is there a case for shoehorning this into
v15 at this late date? Consistency with PQsslAttribute would be
good, but I'm not sure we want to make this kind of change post-RC1.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| clean-up-PQsslAttributeNames.patch | text/x-diff | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-09-29 22:11:42 | Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection |
| Previous Message | Daniel Gustafsson | 2022-09-29 21:37:15 | Re: BUG #17625: In PG15 PQsslAttribute returns different values than PG14 when SSL is not in use for the connection |