From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: GCC 4.4 compiler warnings |
Date: | 2009-04-24 16:15:40 |
Message-ID: | 4669.1240589740@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> GCC 4.4 produces a bunch of new compiler warnings against 8.4; see attached
> output. Some of these are related to our old friend fastgetattr(), but it's a
> bit too late for me to make sense of it now.
> As we have grown accustomed to warnings-free builds, it would be nice to fix
> these.
I've fixed all the 'variable may be used uninitialized' warnings that
I see in a basic build (there might be some others in optional code).
The 'value computed is not used' warnings all seem to come from these
lines in fastgetattr():
(((isnull) != NULL) ? (*(isnull) = false) : (dummyret)NULL), \
...
(((isnull) != NULL) ? (*(isnull) = true) : (dummyret)NULL), \
Since there isn't any obvious better way to do this, I consider this
warning to be a gcc bug, and have filed it accordingly:
https://bugzilla.redhat.com/show_bug.cgi?id=497545
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bill Moran | 2009-04-24 19:45:16 | Re: RFE: Transparent encryption on all fields |
Previous Message | Magnus Hagander | 2009-04-24 08:44:15 | Re: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows. |