| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Reporting script runtimes in pg_regress |
| Date: | 2019-02-15 16:24:53 |
| Message-ID: | 4668.1550247893@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <john(dot)naylor(at)2ndquadrant(dot)com> writes:
> On 2/15/19, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> We should also strive to align "FAILED" properly. This is currently
>> quite unreadable:
>>
>> int4 ... ok (128 ms)
>> int8 ... FAILED (153 ms)
>> oid ... ok (163 ms)
>> float4 ... ok (231 ms)
> If I may play devil's advocate, who cares how long it takes a test to
> fail? If it's not difficult, leaving the time out for failures would
> make them stand out more.
Actually, I'd supposed that that might be useful info, sometimes.
For example it might help you guess whether a timeout had elapsed.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2019-02-15 16:31:30 | Re: explain plans with information about (modified) gucs |
| Previous Message | Peter Eisentraut | 2019-02-15 16:23:57 | Re: Commit Fest 2019-01 is now closed |