Re: [PATCH] Re: pg_identify_object_as_address() doesn't support pg_event_trigger oids

On Tue, Apr 27, 2021, at 09:48, Michael Paquier wrote:
> On Tue, Apr 27, 2021 at 07:16:25AM +0200, Joel Jacobson wrote:
> > I've added a test at the end of event_trigger.sql,
> > reusing the three event triggers already in existence,
> > just before they are dropped.
>
> Cool, thanks. I have been looking at it and I'd still like to
> cross-check the output data of pg_get_object_address() to see if
> pg_identify_object() remains consistent through it. See for example
> the attached that uses a trick based on LATERAL, a bit different than
> what's done in object_address.sql but that gives the same amount of
> coverage (I could also use two ROW()s and an equality, but well..).

Neat trick, looks good to me.

I've successfully tested fix_event_trigger_pg_identify_object_as_address3.patch.

/Joel