| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Hannes Eder <Hannes(at)HannesEder(dot)net> |
| Cc: | pgsql-patches(at)postgresql(dot)org, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, magnus(at)hagander(dot)net |
| Subject: | Re: msvc, build and install with cygwin in the PATH |
| Date: | 2007-05-23 13:50:33 |
| Message-ID: | 465446A9.1050303@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Hannes Eder wrote:
> - open($D, "dir /b $subdirs $spec |") || croak "Could not list $spec\n";
> + open($D, "cmd /c dir /b $subdirs $spec |") || croak "Could not list $spec\n";
>
>
What the heck are we doing here anyway? We should be doing this a la
Perl - calling out to "dir /b" is surely not the best way to do this. If
we need to recurse we should use File::Find.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-23 13:59:12 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Previous Message | Alvaro Herrera | 2007-05-23 13:40:39 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-05-23 13:59:12 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |
| Previous Message | Alvaro Herrera | 2007-05-23 13:40:39 | Re: CREATE TABLE LIKE INCLUDING INDEXES support |