| From: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
|---|---|
| To: | Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Cleanup SubPlanstate |
| Date: | 2024-10-30 02:44:52 |
| Message-ID: | 4653d23f-35ea-4092-9fcc-deccb4043bc7@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/29/24 21:34, Rafia Sabih wrote:
> Hello hackers,
>
> While reviewing a related patch, it came to the notice that tab_eq_funcs
> in the SubPlanState is not used. Hence the patch.
Ok.
My initial doubt in such cases is - may it be the case where we mask a
mistake? But that case looks good. Introduced in ab05eed, the approach
with an equality function for each grouping column was replaced by
bf6c614, which moved the grouping operation execution via the expression
evaluation machinery. That made the tab_eq_funcs useless.
So, I think it may be removed.
--
regards, Andrei Lepikhov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2024-10-30 02:55:21 | RE: Conflict detection for update_deleted in logical replication |
| Previous Message | Andres Freund | 2024-10-30 02:21:32 | Re: AIO writes vs hint bits vs checksums |