| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, ma lz <ma100(at)hotmail(dot)com> |
| Subject: | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |
| Date: | 2025-03-23 01:04:19 |
| Message-ID: | 461405.1742691859@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-general pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> Alias.aliasname is not qualified, so it means that we'd begin to
> assign the same query ID even if using two relations from two schemas
> depending on what search_path assigns, no?
Right. I'm arguing that that's good. The proposed patch already
obscures the difference between similar table names in different
(temp) schemas, and I'm suggesting that taking that a bit further
would be fine.
Note that if the tables we're considering don't have identical
rowtypes, the queries would likely jumble differently anyway
due to differences in Vars' varattno and vartype.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-03-23 01:12:05 | Re: Nested Stored Procedures - ERROR: invalid transaction termination 2D000 |
| Previous Message | Tom Lane | 2025-03-23 00:59:11 | Re: Determine server version from psql script |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2025-03-23 02:09:55 | Re: AIO v2.5 |
| Previous Message | Michael Paquier | 2025-03-23 00:47:31 | Re: query_id: jumble names of temp tables for better pg_stat_statement UX |