| From: | "Tom Dunstan" <pgsql(at)tomd(dot)cc> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tom Dunstan <pgsql(at)tomd(dot)cc>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Current enums patch |
| Date: | 2007-04-02 12:52:40 |
| Message-ID: | 4610fc98.15a.35d1.23451@internode.on.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
> Looks like we need to check the length on type creation
> too.
>
> I'll fix later if not beaten to it.
It works for me (ie fails with an appropriate error) locally
on Linux FC6 x86-64. Perhaps this platform initializes
memory to zero on allocation? I dunno. Anyway, if you can
reproduce it, please have a go, I'm at work and won't be
able to do anything more in depth for some time.
I could have sworn that I had some bounds checking in there
at one point, but it doesn't seem to be in the latest
version of the code. *shrug*. It should be both in
cstring_enum() in enum.c and in DefineEnum() in typecmds.c.
Cheers
Tom
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-04-02 14:08:08 | Re: Blocked post |
| Previous Message | Pavan Deolasee | 2007-04-02 12:19:59 | HOT WIP Patch - version 6.3 |