Re: tsearch2 regression test failures

From: Teodor Sigaev <teodor(at)sigaev(dot)ru>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: tsearch2 regression test failures
Date: 2007-03-26 11:10:05
Message-ID: 4607AA0D.907@sigaev.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Yup, that solved the problem, thanks.
I'll commit extended patch - there is one more place with the same bug.

> Wouldn't it be more efficiently written to walk the string backwards until
> !isspace instead? Not sure that it matters at all, but then you'll
> normallyi never step over more than two bytes...
It doesn't significant matter - file reads once per backend lifetime.

--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2007-03-26 11:16:31 Re: tsearch2 regression test failures
Previous Message Richard Huxton 2007-03-26 11:03:08 Re: Group Commit