Re: OS timezone files support

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: OS timezone files support
Date: 2007-03-22 18:35:44
Message-ID: 4602CC80.90309@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Magnus Hagander wrote:
> Tom Lane wrote:
>> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>>> This patch brings possibility to switch from default build-in timezone
>>> to another timezone source - typically to OS timezone location.
>>> It was discussed few weeks ago:
>>> http://archives.postgresql.org/pgsql-hackers/2007-03/msg00784.php
>> AFAIR, the conclusion of that discussion was we didn't want it.
>>
>> I certainly don't see the point of the implementation as you have it
>> --- it adds a great deal of unnecessary infrastructure compared to just
>> installing a symlink at share/postgresql/timezone.
>
> And if you wanted it in the backend instead of a symlink, shouldn't it
> at least try to verify that the files in the timezone directory are
> compatible before blindly accepting it?

I think that packager is responsible for verification his integration.
It is same in both cases (configure or link solution). I'm not sure if
it is necessary make check of timezone validity during build time. Build
environment should be different from target system.

If you talk about checking timezone files on runtime, I hope Postgres
verify timezone files every time.

Zdenek

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-03-22 19:43:24 Re: [DOCS] suggestion for improving TMPDIR and "--format" docs for pg_dump
Previous Message Tom Lane 2007-03-22 18:23:03 Re: OS timezone files support