From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_resetxlog bug? |
Date: | 2009-05-03 23:17:09 |
Message-ID: | 4601.1241392629@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Fujii Masao <masao(dot)fujii(at)gmail(dot)com> writes:
> Current pg_resetxlog doesn't remove any archive status files. This
> may cause continuous failure of archive command since .ready file
> remains even if a corresponding XLOG segment is removed. And,
> .done file without XLOG segment cannot be removed by checkpoint,
> and would remain forever. These are undesirable behaviors.
> I think that pg_resetxlog should remove existing archive status files
> of XLOG segments. Here is the patch to do so.
Applied with a trivial fix (the ending value of "path" isn't necessarily
right for a complaint about directory read failure, so use a constant
instead).
I back-patched as far as 8.1. The issue exists in 8.0 too, but the
patch didn't apply immediately to 8.0 because of the above issue.
Given the lack of field complaints and 8.0's rather legacy status,
it didn't seem worth expending extra effort on.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2009-05-04 00:43:22 | Re: windows doesn't notice backend death |
Previous Message | Tom Lane | 2009-05-03 22:04:17 | Re: windows doesn't notice backend death |