| From: | Erik Wienhold <ewie(at)ewie(dot)name> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | jian he <jian(dot)universality(at)gmail(dot)com>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add column name to error description |
| Date: | 2025-03-07 03:36:15 |
| Message-ID: | 45bdc699-5606-4a00-86d7-46ca42d5ad4a@ewie.name |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-03-07 04:05 +0100, Tom Lane wrote:
> Erik Wienhold <ewie(at)ewie(dot)name> writes:
> > But I don't see the point in keeping variables atttypid and atttypmod
> > around when those values are now available via outatt. Removing these
> > two variables makes the code easier to read IMO. Done so in the
> > attached v4.
>
> I think the idea of the original coding was to keep those values in
> registers in the inner loop rather than re-fetching them each time.
Could be. But the main reason was to hold the output column type as the
inner loop repurposed att for the input column. With the separate
outatt and inatt this is no longer necessary.
--
Erik Wienhold
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-03-07 03:48:16 | Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row |
| Previous Message | Chiranmoy.Bhattacharya@fujitsu.com | 2025-03-07 03:20:07 | Re: [PATCH] SVE popcount support |