| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: ResourceOwner refactoring |
| Date: | 2024-06-06 11:32:38 |
| Message-ID: | 45bc67c6-85f6-4c5b-a701-9b59d81afcf7@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 05/06/2024 16:58, Heikki Linnakangas wrote:
> On 04/06/2024 01:49, Heikki Linnakangas wrote:
>> A straightforward fix is to modify RelationFlushRelation() so that if
>> !IsTransactionState(), it just marks the entry as invalid instead of
>> calling RelationClearRelation(). That's what RelationClearRelation()
>> would do anyway, if it didn't hit the assertion first.
>
> Here's a patch with that straightforward fix. Your test case hit the
> "rd_createSubid != InvalidSubTransactionId" case, I expanded it to also
> cover the "rd_firstRelfilelocatorSubid != InvalidSubTransactionId" case.
For the record, I got the above backwards: your test case covered the
rd_firstRelfilelocatorSubid case and I expanded it to also cover the
rd_createSubid case.
> Barring objections, I'll commit this later today or tomorrow. Thanks for
> the report!
Committed.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2024-06-06 11:45:51 | Re: Conflict Detection and Resolution |
| Previous Message | Andrew Dunstan | 2024-06-06 11:25:26 | Re: ssl tests fail due to TCP port conflict |