Re: pg_dump pretty_print

From: "Greg Sabino Mullane" <greg(at)turnstep(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: Re: pg_dump pretty_print
Date: 2007-01-22 19:53:40
Message-ID: 45a8e38381d8411d9183f0583341f53d@biglumber.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter Eisentraut asked:
> Could you provide a less hand-waving specification of this feature? At
> the moment it sounds like "This option does something fun, but we're
> not sure what it is.

Sure. Perhaps after I manage to convince Tom of its usefullness. :)
I can expand on what "pretty" is and add a warning akin to the
one for --tables.

Tom Lane asked:

> Why exactly is that a good idea? Seems like a foot-gun with marginal
> usefulness. If you want to look at things "pretty", the psql \d
> commands are the tool to use.

Because sometimes all you have is access to the dump file, or because you
want to save/view a historical record; in both cases it is very hard
to actually read the input when it's crammed into a single line with minimal
whitespacing. Since we already do make some concessions as far as making
the dump file human-readable, offering this as an *optional* flag seems
(mostly) harmless.

- --
Greg Sabino Mullane greg(at)turnstep(dot)com
PGP Key: 0x14964AC8 200701221450
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFFtRV1vJuQZxSWSsgRAm4iAJ9lro5hvpbYHQB6fM06uH7wUHzLlwCgpamm
wUpTmpqn4JbcEGsHmM1OTPQ=
=HrpY
-----END PGP SIGNATURE-----

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-01-22 19:54:01 Re: [HACKERS] Win32 WEXITSTATUS too
Previous Message Tom Lane 2007-01-22 19:48:33 Re: [HACKERS] Win32 WEXITSTATUS too

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-01-22 19:54:01 Re: [HACKERS] Win32 WEXITSTATUS too
Previous Message Tom Lane 2007-01-22 19:48:33 Re: [HACKERS] Win32 WEXITSTATUS too