Re: pgsql: Bumping catversion due to changes to pg_trigger and pg_rewrite.

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Bumping catversion due to changes to pg_trigger and pg_rewrite.
Date: 2007-03-20 04:08:02
Message-ID: 45FF5E22.2010906@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 3/20/2007 12:00 AM, Neil Conway wrote:
> Jan Wieck wrote:
>> BTW, the comment in this file says that we hope we never have more than
>> 10 catversion changes per day, but to even make this possible we should
>> start counting at zero, shouldn't we?
>>
>
> The comment says "hopefully we'll never commit ten independent sets of
> catalog changes on the same day" (not > 10), so the comment isn't wrong.
> But I guess there wouldn't be any harm at starting at zero...

Since the entire catversion number is used as an integer, counting 0...9
vs. 1...0 makes quite a difference. And that difference manifests itself
>9, not >10.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2007-03-20 04:10:16 Re: [COMMITTERS] pgsql: Bumping catversion due to changes to pg_trigger and pg_rewrite.
Previous Message Neil Conway 2007-03-20 04:00:19 Re: pgsql: Bumping catversion due to changes to pg_trigger and pg_rewrite.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-03-20 04:10:16 Re: [COMMITTERS] pgsql: Bumping catversion due to changes to pg_trigger and pg_rewrite.
Previous Message Neil Conway 2007-03-20 04:00:19 Re: pgsql: Bumping catversion due to changes to pg_trigger and pg_rewrite.