Re: bgwriter stats

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: bgwriter stats
Date: 2007-03-19 20:02:05
Message-ID: 45FEEC3D.9080700@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway wrote:
> Magnus Hagander wrote:
>> Anyway. Attached patch adds this to the bgwriter shared memory. Is it
>> safe to do this, and then just have a regular function running in a
>> normal backend pulling out the value and returning it to the user,
>> without locking?
> If the variable is an int64, I don't believe so: the architecture might
> not implement atomic read/writes of int64 values.

Ok. But it should be safe if it's int32?

Actually, since it's just statistics data, it wouldn't be a problem that
it's not atomic, I think. If we really unlucky, we'll get the wrong
value once. But most systems that poll such statistics can deal with
that, in my experience.

Then again, a normal int shouldn't be a problem either.

//Magnus

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2007-03-19 20:18:20 Re: bgwriter stats
Previous Message Neil Conway 2007-03-19 19:57:54 Re: bgwriter stats