From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bison 2.1 on win32 |
Date: | 2007-03-17 16:17:11 |
Message-ID: | 45FC1487.3060906@hagander.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> The attached patch seems to fix the build issue. Does it seem
>> acceptable/the right thing to do?
>
> No, it seems pretty bletcherous.
That's kind of what I thought :-)
>> Another option would be to just reject both 2.0 and 2.1 as broken to
>> build pg with, I guess...
>
> In bison 2.3 (which is shipping with Fedora Core 6), all the uses of
> __STDC__ seem to also test _MSC_VER:
>
> #if (defined __STDC__ || defined __C99__FUNC__ \
> || defined __cplusplus || defined _MSC_VER)
>
> If this fixes the problem, then I'd vote for just stating you need
> bison >= 2.3 (or 2.2?) to build on MSVC.
It certainly looks like it would fix it. However, the gnuwin32 project
doesn't have 2.3, not even 2.2. But let's add a check and say we need
it, and then we can fix it again once they do release that version if
it's broken still...
Do you happen to have a 2.2 around so you can see what happens there? Or
does someone else have that? So I know which version to test against...
//Magnus
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2007-03-17 16:23:07 | Re: Bug in UTF8-Validation Code? |
Previous Message | Tom Lane | 2007-03-17 16:10:06 | Re: Bug in UTF8-Validation Code? |