| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | a(dot)imamov(at)postgrespro(dot)ru |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Potential issue in ecpg-informix decimal converting functions |
| Date: | 2024-03-25 13:43:59 |
| Message-ID: | 45F3E0EF-2651-4668-BCF4-C391DF2AD82D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 6 Mar 2024, at 20:12, a(dot)imamov(at)postgrespro(dot)ru wrote:
> I agree with the proposed changes in favor of backward compatibility.
I went ahead to pushed this after another look. I'm a bit hesitant to
backpatch this since there are no reports against it, and I don't have good
sense for how ECPG code is tested and maintained across minor version upgrades.
If we want to I will of course do so, so please chime in in case there are
different and more informed opinions.
> Also, is it a big deal that the PGTYPESnumeric_to_long() function doesn't
> exactly match the documentation, compared to PGTYPESnumeric_to_int()? It
> handles underflow case separately and sets errno to PGTYPES_NUM_UNDERFLOW
> additionally.
Fixed as well.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pankaj Raghav | 2024-03-25 13:53:56 | Re: Large block sizes support in Linux |
| Previous Message | Robert Haas | 2024-03-25 13:26:57 | Re: pgsql: Track last_inactive_time in pg_replication_slots. |