From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
Date: | 2007-03-09 14:49:24 |
Message-ID: | 45F173F4.9010609@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Magnus Hagander wrote:
> In which case it can simply be because I was building against a libpq
> built with MSVC = it had the broken startup code, and you used a mingw
> one, which didn't have it.
Maybe - but it does imply it's potentially easy to break code with this
change.
> Per the docs, an application like slon *should* make it's own call to
> WSAStartup() because it uses socket functions diretly (port/pipe.c)...
>
>
> Another question related to backpatching - should I backpatch this to
> 8.1 and 8.0 as well? I know we said we more or less don't maintain the
> win32 port back there because it was too new, but this is all code in
> the client libpq, which has been around no win32 much longer. The reason
> I'm asking is that the original reporter of this problem is on 8.1...
>
> I'm leaning towards yes, but would like to hear further comments...
I'm far from convinced it should be backpatched at all.
/D
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-03-09 16:00:47 | Re: Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
Previous Message | Magnus Hagander | 2007-03-09 11:33:08 | Re: [COMMITTERS] pgsql: Remove unsafe calling of WSAStartup and WSA Cleanup from DllMain. |
From | Date | Subject | |
---|---|---|---|
Next Message | Martijn van Oosterhout | 2007-03-09 14:54:01 | Re: Calculated view fields (8.1 != 8.2) |
Previous Message | Greg Smith | 2007-03-09 13:57:48 | Re: Log levels for checkpoint/bgwriter monitoring |