From: | Dave Page <dpage(at)postgresql(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: Patch for column properties |
Date: | 2007-03-02 10:04:38 |
Message-ID: | 45E7F6B6.50202@postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Guillaume Lelarge wrote:
> Hi,
>
> When someone set a default value for a column and set NOT NULL at the
> same time, the query could fail if the table already contains NULL
> values for this column. This patch adds an UPDATE statement to put the
> DEFAULT value in this column for all NULL values (but only when you SET
> NULL and SET DEFAULT the column at the same time).
>
> I've done this patch for a friend but I don't quite like this patch
> because of its behaviour. It doesn't warn the user. I think it would be
> better to show a dialog telling that an UPDATE statement will be
> executed because otherwise the whole action could fail.
>
> So here are some questions :
> * do you think this patch is worth it ?
I'm not keen on the idea.I prefer to leave that sort of behaviour to the
server, *if* thats the way it gets written.
Regards, Dave
From | Date | Subject | |
---|---|---|---|
Next Message | svn | 2007-03-02 10:57:01 | SVN Commit by dpage: r5964 - in trunk/pgadmin3: . pgadmin/db pgadmin/frm pgadmin/include/schema pgadmin/include/utils pgadmin/schema |
Previous Message | Hiroshi Saito | 2007-03-02 00:30:06 | Re: Lack in PostgreSql (8.2.x, 8.1.x, 8.0.x) and pgAdmin (1.6.x) updated builds (build service) |