| From: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | John Bartlett <johnb(at)fast(dot)fujitsu(dot)com(dot)au> |
| Cc: | pgsql-patches(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: |
| Date: | 2007-02-27 11:03:12 |
| Message-ID: | 45E40FF0.6070302@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
John Bartlett wrote:
> The community may wish to comment on the following issue:
>
> 1) At present the file that will contain the list of ctids is going into
> a new directory called pg_ctids, analogous to pg_twophase, and also stored
> in the pg_data directory.
I don't understand this. What's stored in the file and why? If they're
only needed within the transaction, surely a temp file would be more
appropriate?
The new ctidListStore.c file in the patch is not in a valid diff-format.
I also noticed that you've moved the line beginning with "CREATE_ROLE"
in gram.y so that it's not in alphabetical order anymore.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2007-02-27 13:34:26 | Re: HOT WIP Patch - version 3.2 |
| Previous Message | Simon Riggs | 2007-02-27 10:49:32 | Re: COMMIT NOWAIT Performance Option |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ITAGAKI Takahiro | 2007-02-27 11:51:36 | Re: patch for ECPG (BUG #2956: ECPG does not treat multibyte characters correctly.) |
| Previous Message | Chris Marcellino | 2007-02-27 10:24:46 | Re: POSIX shared memory support |