| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Yoshiyuki Asaba <y-asaba(at)sraoss(dot)co(dot)jp>, ZeugswetterA(at)spardat(dot)at, andrew(at)dunslane(dot)net, z-saito(at)guitar(dot)ocn(dot)ne(dot)jp, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_restore fails with a custom backup file |
| Date: | 2007-02-17 19:40:54 |
| Message-ID: | 45D75A46.8050303@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> I'd also like a comment from at least one other "patch reviewer" that
>> the methods used are good.
>
> It looks reasonable as far as it goes. One thought is that pg_dump
Ok. I'll run some more tests and then get it in.
> really should have noticed that it was writing a broken archive.
> On machines where off_t is 32 bits, can't we detect the overflow
> situation?
IIRC, there was a warning from pg_dump. I don't recall exactly what, and
don't have the space to re-run the test on my laptop here, but I think
it was from:
write_msg(modulename, "WARNING: ftell mismatch with expected position --
ftell used\n");
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-02-17 19:43:14 | Re: patch adding new regexp functions |
| Previous Message | Jeremy Drake | 2007-02-17 19:32:58 | Re: patch adding new regexp functions |