| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Fuhr <mike(at)fuhr(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] \copy (query) delimiter syntax error |
| Date: | 2007-02-03 19:54:24 |
| Message-ID: | 45C4E870.8080202@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Michael Fuhr wrote:
> On Sat, Feb 03, 2007 at 10:52:29AM -0600, Andrew Dunstan wrote:
>
>> I'd say fix psql. Not sure how far back we should backpatch it. It's
>> interesting that this has been there since 8.0 and is only now discovered.
>>
>
> The problem is new in 8.2 because COPY (query) doesn't support USING
> DELIMITERS. COPY tablename does, so it has worked all along.
>
>
oh, good point. OK, I have cut this quick patch that will continue to
accept the legacy syntax in psql in non-inline-query cases, but will
make psql unreservedly emit new style syntax for COPY to the backend.
Does that seem reasonable, or is it too much of a change for the stable
branch?
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| copy.patch | text/x-patch | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Wieck | 2007-02-03 20:52:50 | Re: Proposal: Commit timestamp |
| Previous Message | Matthias Luedtke | 2007-02-03 19:02:36 | Re: --enable-debug does not work with gcc |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-02-03 23:46:56 | Re: date comparisons |
| Previous Message | Michael Fuhr | 2007-02-03 17:12:07 | Re: \copy (query) delimiter syntax error |