Re: Allow dumping of roles or tablespaces

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dave Page <dpage(at)postgresql(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Allow dumping of roles or tablespaces
Date: 2007-01-12 15:24:42
Message-ID: 45A7A83A.5090807@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Dave Page <dpage(at)postgresql(dot)org> writes:
>
>> pg_dumpall -g -- Dump roles and tablespaces per current behaviour
>> pg_dumpall -gr -- Dump roles only (or users and groups)
>> pg_dumpall -gt -- Dump tablespaces only
>>
>
> This seems a bit ugly, mainly because (1) it doesn't have a natural
> translation to long-form switches, and (2) it screws up the usual
> habit of merging multiple single-letter switches into one argument.
> Perhaps something like
>
> --roles-only
> --tablespaces-only
> --globals-only
>
> Not sure if there are free single-letter codes for the first two,
> but on the whole I'm more interested in having sane long-form names
> than sane short ones ...
>
>
>

I agree. In fact, as I understand the patch it would also allow "-g r"
and "-g t", and that seems ugly too.

We don't have to have a short form for every long option - e.g. initdb
has several like --no-locale for which there is no corresponding short
form. I suggest we make the new options long form only, along the lines
Tom suggests.

cheers

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2007-01-12 15:29:58 Re: Allow dumping of roles or tablespaces
Previous Message Tom Lane 2007-01-12 15:05:49 Re: Allow dumping of roles or tablespaces