| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> | 
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> | 
| Cc: | pgsql-hackers(at)postgresql(dot)org, oleg(at)sai(dot)msu(dot)su | 
| Subject: | Re: Request for review: tsearch2 patch | 
| Date: | 2007-01-10 15:50:44 | 
| Message-ID: | 45A50B54.6090608@sigaev.ru | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
> I have tested with local-enabled environment and found a bug. Included
> is the new version of patches. 
Your patch causes crash on tsearch2's installcheck with 'initdb -E UTF8 --locale 
C', simple way to reproduce:
# select to_tsquery('default', '''New York''');
server closed the connection unexpectedly
         This probably means the server terminated abnormally
         before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
>> ! static int p_isalnum(TParser *prs) {
...
>> ! 		if (lc_ctype_is_c())
>> ! 		{
>> ! 			if (c > 0x7f)
>> ! 				return 1;
I have some some doubts that any character greater than 0x7f is an alpha symbol. 
Is it simple assumption or workaround?
-- 
Teodor Sigaev                                   E-mail: teodor(at)sigaev(dot)ru
                                                    WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2007-01-10 16:22:11 | Re: [HACKERS] [PATCHES] Last infomask bit | 
| Previous Message | Tom Lane | 2007-01-10 15:46:31 | Re: Mark/Restore and avoiding RandomAccess sorts |