| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Hans-Jürgen Schönig <postgres(at)cybertec(dot)at>, Boszormenyi Zoltan <zb(at)cybertec(dot)at>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: plan time of MASSIVE partitioning ... |
| Date: | 2010-09-08 16:03:48 |
| Message-ID: | 4593.1283961828@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost <sfrost(at)snowman(dot)net> writes:
> Indeed, but code like this makes me wonder if this is really working the
> way it's supposed to:
> + val1 = (long)pk_left->pk_eclass;
> + val2 = (long)pk_right->pk_eclass;
Ugh. Casting a pointer to long? We do have portable ways to do what
this is trying to do, but that is not one. (For example, this is
guaranteed to misbehave on 64-bit Windows.)
Offhand I think PointerGetDatum might be the best way.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2010-09-08 16:05:06 | Re: "serializable" in comments and names |
| Previous Message | Boszormenyi Zoltan | 2010-09-08 15:58:09 | Re: plan time of MASSIVE partitioning ... |