| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Date: | 2018-11-26 21:19:55 |
| Message-ID: | 459131543267195@sas1-4b7566131ec9.qloud-c.yandex.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi
> I'd encourage you to look through the diff after you're finished hacking
> before sending it to the list, in case things get left in that should be
> removed, as below...
I am so sorry. I have a look before sending, but...
It's night in my timezone. I will fix tomorrow.
>> + if (targetSettingsCount > 1)
>> + ereport(FATAL,
>> + (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>> + errmsg("can not specify multiple recovery targets")));
>
> Doesn't look like you changed this based on my prior comment..?
Do you mean this one?
> I think I would have done 'if (targetSettingsCount != 1)' here.
To be sure, we need check we have one recovery target without standby mode and none or one in standby mode? Or some another check?
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-11-26 21:22:53 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Previous Message | Stephen Frost | 2018-11-26 20:48:55 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2018-11-26 21:22:53 | Re: pgsql: Integrate recovery.conf into postgresql.conf |
| Previous Message | David Rowley | 2018-11-26 21:19:21 | Re: Inadequate executor locking of indexes |