Re: 8.2 Partition lock changes and resource queuing.

From: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: 8.2 Partition lock changes and resource queuing.
Date: 2006-12-11 01:56:52
Message-ID: 457CBAE4.8030500@paradise.net.nz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Mark Kirkwood <markir(at)paradise(dot)net(dot)nz> writes:
>> The other approach I wondered about was arranging for the resource locks
>> and related data structures to all use an *additional* partition lock -
>> which would mean faking a LOCKTAG that always hashed to
>> NUM_LOCK_PARTITIONS, and using that everywhere in the resource code...
>
> That seems mighty ugly, as well as defeating the purpose of spreading
> the LWLock contention around evenly.

Yes - and possibly confusing to amend later, when I (or someone else)
had forgotten why it was done that way...

> I'd go for letting the resource
> locks go into their natural hash partitions, and making a separate LWLock
> for your other data structures. (Some day you might get to the point of
> wanting to partition the other data structures, in which case you'd be
> glad you separated the locks.)

Great, thanks for the quick reply!

Cheers

Mark

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message t-ishii 2006-12-11 02:37:22 Re: Administration
Previous Message Tom Lane 2006-12-11 01:34:05 Re: psql display of Unicode combining characters in 8.2