From: | Joseph S <jks(at)selectacast(dot)net> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: doc patch for savepoints |
Date: | 2006-11-28 02:08:21 |
Message-ID: | 456B9A15.6030705@selectacast.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
>> On Mon, 2006-11-27 at 17:48 -0500, Tom Lane wrote:
>>> I do not see the point of this. Shall we put equivalent disclaimers
>>> into every single construct that consumes shared memory?
>
>> Stating that it uses shared memory? Absolutely. Stating that you may run
>> out? No, ...
>
> Well, the fact that it uses shared memory is an uninteresting
> implementation detail --- at least, it's uninteresting until you run
> out. When/if that happens, ISTM the error message and HINT are plenty
> good enough to tell you what to do about it.
No, when you run out it is not obvious that your unreleased savepoints
are causing the problem.
To further help diagnose shared memory problems maybe in pg_locks there
should be the sql that caused the lock to come into existence, like
current_query in pg_stat_activity.
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2006-11-28 02:22:41 | Re: [BUGS] Out of memory error causes Abort, Abort tries |
Previous Message | Joseph S | 2006-11-28 02:01:16 | Re: doc patch for savepoints |
From | Date | Subject | |
---|---|---|---|
Next Message | Simon Riggs | 2006-11-28 09:22:37 | Re: Configuring BLCKSZ and XLOGSEGSZ (in 8.3) |
Previous Message | Joseph S | 2006-11-28 02:01:16 | Re: doc patch for savepoints |