| From: | Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: logical decoding and replication of sequences |
| Date: | 2022-03-22 12:11:29 |
| Message-ID: | 456A528F-8F19-41C7-9857-927024D32396@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 22. 3. 2022, at 13:09, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Mar 21, 2022 at 4:25 AM Tomas Vondra
> <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>>
>> Hi,
>>
>> Attached is a rebased patch, addressing most of the remaining issues.
>>
>
> It appears that on the apply side, the patch always creates a new
> relfilenode irrespective of whether the sequence message is
> transactional or not. Is it required to create a new relfilenode for
> non-transactional messages? If not that could be costly?
>
That's a good catch, I think we should just write the page in the non-transactional case, no need to mess with relnodes.
Petr
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikita Malakhov | 2022-03-22 12:18:55 | Re: Pluggable toaster |
| Previous Message | Amit Kapila | 2022-03-22 12:09:31 | Re: logical decoding and replication of sequences |