Re: BUG #2677: BCC 5.5 can't compile libpq 8.2 beta 1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "CN" <cnliou9(at)fastmail(dot)fm>
Cc: pgsql-bugs(at)postgresql(dot)org, Magnus Hagander <mha(at)sollentuna(dot)net>
Subject: Re: BUG #2677: BCC 5.5 can't compile libpq 8.2 beta 1
Date: 2006-10-06 19:00:26
Message-ID: 4565.1160161226@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

"CN" <cnliou9(at)fastmail(dot)fm> writes:
> Warning W8017 ..\..\include\pg_config.h 366: Redefinition of 'HAVE_STRDUP'
> is not identical

I was wondering why all the .mak files bother to /D HAVE_STRDUP when
they don't deal with any of the other ones. Shouldn't we remove that?
pg_config.h.win32 is certainly the right place to be handling this.

> Error E2209 ..\..\include\c.h 64: Unable to open include file 'crtdefs.h'

Does this exist for any Borland releases? Dropping it into an
#if defined(__BORLANDC__) || defined(_MSC_VER)
was probably a mistake.

> Error E2209 ..\..\include\c.h 88: Unable to open include file
> 'pg_config_os.h'

Oversight, fixed this one.

> Error E2040 ..\..\include\port.h 336: Declaration terminated incorrectly

Not sure about this ... could random() be defined as a macro in your
installation? (Is that pointing at the definition of random()? I'm not
real sure which version of port.h you have.) If so, we could fix it by
adding #define HAVE_RANDOM to pg_config.h.win32, but I'm not sure if
that has to be conditional on __BORLANDC__ ... do Mingw and MSVC not
have that function?

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2006-10-06 19:02:23 Re: BUG #2674: libedit not detected
Previous Message Tom Lane 2006-10-06 16:35:49 Re: BUG #2678: Create or replace function with OUT args