Re: Test results for 1.6RC2 rev: 5636M

Erwin Brandstetter wrote:
> Hi developers! Hi Dave!
>
> Testing 1.6RC2 rev: 5636M, client Win XP.
>
> # One more cornercase for "Find and Replace". Try to replace multiple
> occurrences of 'abc' with 'abcd' and see for yourself ..
> Seems like "Replace" continues the search at the _beginning_ of the
> newly inserted text. If the search string is included in the replace
> string, we end up in an endless loop.
> Might be easy to fix by continuing the search _after_ the replaced
> string. ("Find" seems to do it right.)

OK, got that one.

> dpage(at)postgresql(dot)org wrote:
>> Figured out a way to check for modification more sensibly, so we can
>> now disable the buttons on column change.
>
> That's very good news! Not only have you fixed the issue at hand, you
> also got rid of other unnecessary save dialogues (we have been
> discussing before). The latter is even the greater improvement, IMO.
> I have my doubts you want to hear of this, but I have still found an
> (even less important) cornercase. :)
> If I stay _on_ the not edited cell and just press <esc> to leave edit
> mode, I can still trigger the previously discussed issues.

Yeah, that ones a bit more tricky to solve :-(

Thanks, Dave