Re: edit grid: issues involving marking, selecting,

Erwin Brandstetter wrote:
> Hi developers! Hi Dave!
>
> Testing RC2. Client Win XP, Server Debian Sarge, PostgreSQL 8.1.4.
>
> I think I have found more issues in the edit grid, which have some
> potential to damage things.

<Snip comprehensive bug report>

I've committed some changes which I think address most of the issues you
mentioned. A bit of background on the copy/paste thing first though for
info:

- pgAdmin has no knowledge of the format of data on the clipboard - it
simply checks that it is text that it can do something with.

- The wxGrid control has both selections and a cursor. Selections are
rows/columns/cells that are highlighted. The cursor is the cell with the
thick border. These concepts can be a cause of confusion for us as well
as end users unfortunately (long time list members will remember
Andreas' hatred of the control). At the moment though, it's all we've got.

- If you are in edit mode in a cell, a paste operation will insert the
data into that cell where possible.

- If you are not in edit mode, no matter where the cursor cell is, the
paste operation will happen on the 'new' row at the bottom. The data
will be split based on the Copy column seperator and quote character
(see File -> Options -> Query), and the columns populated sequentially.
If any column is a serial, the data in that position will be left
blank if you choose.

So, onto the changes I've made:

1) When a new row paste occurs, the cursor cell is moved to the position
of each column as data is inserted, such that it will be on the last
affected cell when the paste has completed. This ensures that any undo
operation will happen on the correct row.

2) When the new row paste is completed, the Save and Undo options are
enabled.

3) When an Undo has been performed, the Undo and Save buttons are disabled.

I think it's all working as it should now apart fromt he know issue that
things get marked dirty upon edit mode start, rather than when the data
is actually changed. But that's much harder to fix as we already
discussed. I'll send you an exe off list.

> Sorry to bring this up so close to release. I did not find it any
> earlier. Anyway, it is up to you what you fix, what you postpone and
> what you reject.

I'll fix what I can - but we are getting very close to release now so I
will be much more critical about what is or isn't a showstopper -
especially as I think they are becoming corner cases far more often.

Thanks for the reports though, they are appreciated even if frustrating!

Regards, Dave.