Re: A couple of quirks in the edit grid

From: Dave Page <dpage(at)postgresql(dot)org>
To: Erwin Brandstetter <brandstetter(at)falter(dot)at>
Cc: pgadmin-support(at)postgresql(dot)org
Subject: Re: A couple of quirks in the edit grid
Date: 2006-11-02 16:18:10
Message-ID: 454A1A42.1090105@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

Erwin Brandstetter wrote:
> Hi developers! Hi Dave!
>
> Testing bet4, rev. 5567:5572 on Win XP
> I found a couple of quirks in the edit grid.
>
> - If I mark part of the text in a field and press <del> only first
> character of the marked text gets deleted. One would expect all of the
> marked text to be deleted. (That's what happens if I press the <back> key)

Fixed in SVN.

> - Boolean field: Cycling through the values by hitting <space> starts
> the cycles differently from clicking with the mouse.
> The regular cycle is FALSE - TRUE - NULL. Mouse click follows that order
> at all times. But <space> doesn't at the start, which is confusing.
> If the field is TRUE, it goes to FALSE first, then starts the cycle.
> If it is NULL, it goes to TRUE first, then starts the regular cycle.
> If it is FALSE, it works as expected.

They're actually doing different things the way you have tested. The
mouse works in one of two ways:

1) It begins an edit on the field, then cycles through the values
allowed by the underlying checkbox control. The new value is set when
the cell loses focus. This occurs when you click directly on the checkbox.

2) It begins an edit on the field, cycles to the next value, and stores
the value, returning the cell to the text value

The space bar works per 1).

This behaviour is somewhat difficult to change in a sensible way, and is
not something I'm going to try to fix this close to release, if at all.

> - Boolean field: If I edit a boolean field, then switch the focus to
> another application and switch back, the field is still highlighted, the
> value has changed back to text (from the little box icon) and keystrokes
> are being ignored. <Esc> doesn not help. Nothing happens until I click
> with the mouse. Does not happen with text or integer fields.

Either Windows or wxWidgets is not causing the appropriate event to fire
when the keypress re-occurs on the cell. I don't know how this can be
fixed unfortunately.

> - If I mark a field (to copy the text) without changing anything, then
> hit <Esc> to unselect again, the edit grid still (incorrectly) tells me,
> that ..
> "There is unsaved data in a row
> Do you want to store to the database?"

Data is currently flagged as dirty as soon as an edit on a cell begins,
not when the data is first changed. This behaviour is also somewhat
difficult to change in a sensible way (though less so than your second
issue), and is not something I'm going to try to fix this close to release.

> - <tab> key jumps to next column in the edit grid. It stops at the last
> column. Other spreadsheet-applications would keep going and jump to the
> first column of the next row. (But maybe that is by design?)

By design of the wxGrid control, yes.

Thanks, Dave.

In response to

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Erwin Brandstetter 2006-11-02 22:10:07 Issue in "Find and Replace"
Previous Message Erwin Brandstetter 2006-11-02 11:42:35 A couple of quirks in the edit grid