| From: | Michael Paesold <mpaesold(at)gmx(dot)at> |
|---|---|
| To: | Dave Cramer <pg(at)fastcrypt(dot)com> |
| Cc: | pgsql-jdbc(at)postgresql(dot)org, Kris Jurka <books(at)ejurka(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [pgsql-jdbc] dollar-quoted CREATE FUNCTION statement fails |
| Date: | 2006-11-02 08:13:28 |
| Message-ID: | 4549A8A8.1060106@gmx.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-jdbc |
Dave Cramer wrote:
> On 1-Nov-06, at 8:19 PM, Michael Paesold wrote:
>
>> Hi Dave,
>>
>> first, I forgot to say that I did do performance tests using the
>> previously posted test case. The new version is definitely faster than
>> the original code, although only marginally. When doing my first
>> version of the patch, I tested different code constructs for speed. I
>> chose the one with the best performance.
>>
>> I ran the tests with both 1.4.2 and 1.5.0. It might be possible that
>> the performance will be worse in an earlier versions of the JDK with a
>> less sophisticated hot-spot compiler.
>
> Cool my comments were pretty minor anyway.
Nevertheless, attached is an updated patch that adds the two missing
"default: break;" cases to the switch statements for better readability.
Best Regards
Michael Paesold
| Attachment | Content-Type | Size |
|---|---|---|
| jdbc-parser.patch | text/x-patch | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Schaber | 2006-11-02 09:57:28 | Re: calling java stored functions through jdbc gives errors. |
| Previous Message | Alex Stienstra | 2006-11-02 07:54:26 | calling java stored functions through jdbc gives errors. |