| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Is WAL_DEBUG related code still relevant today? |
| Date: | 2023-12-02 22:46:39 |
| Message-ID: | 454368.1701557199@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Sat, Dec 02, 2023 at 07:36:29PM +0530, Bharath Rupireddy wrote:
>> I started to think if this code is needed at all in production. How
>> about we do either of the following?
> Well, the fact that this code is hidden behind an off-by-default macro
> seems like a pretty strong indicator that it is not intended for
> production. But that doesn't mean we should remove it.
Agreed, production is not the question here. The question is whether
it's of any use to developers either. It looks to me that the code's
been broken since v13, if not before, which very strongly suggests
that nobody is using it. Think I'd vote for nuking it rather than
putting effort into fixing it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-12-02 23:48:49 | Re: postgres_fdw test timeouts |
| Previous Message | Joe Conway | 2023-12-02 22:43:52 | Re: Emitting JSON to file using COPY TO |