| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: outfuncs.c utility statement support |
| Date: | 2017-06-22 03:02:45 |
| Message-ID: | 451c4c55-76f7-ad21-1476-2d998290f9cf@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 6/18/17 10:14, Tom Lane wrote:
> pg_strtok recognizes "<>" and returns length = 0, so debackslash()
> would produce the right answer AFAICS (admittedly, I haven't tested).
> But I don't really want to do it like that because of the wasted
> palloc space and cycles.
>
>> Maybe
>> local_node->fldname = length ? token[0] : '\0';
>> ?
>
> Doesn't cope with backslash-quoted characters. If we're going to bother
> to do anything here, I think we ought to make it reversible for all
> possible characters.
Makes sense. Updated patch attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-output-of-char-node-fields.patch | text/plain | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-06-22 03:05:19 | Re: pg_terminate_backend can terminate background workers and autovacuum launchers |
| Previous Message | Michael Paquier | 2017-06-22 03:00:36 | Re: Pluggable storage |