From: | schabi at logix-tt(dot)com (Markus Schaber) |
---|---|
To: | |
Subject: | [Pljava-dev] Patch for SQLInput implementation |
Date: | 2006-09-22 15:46:42 |
Message-ID: | 45140562.9070003@logix-tt.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pljava-dev |
Hi, Thomas,
Here's my first attempt for the SQLInput side. (I did not live-test it,
and I possibly broke your formatting wr/t tabs/spaces.)
It fetches the Endianness from ByteOrder, and changes readShort(),
readInt() and readLong() accordingly.
I also refactored the readBytes() method to use readShort() internally
for the length tag (or should we change the length to int, while we're
at it?)
Additionally, I added some missing m_handle checks, and moved the
m_position check into the synchronized block at read() (which is
necessary from my understanding of the java memory model, as position
and chunkSize are both not volatile).
Could you have a quick look at it?
The SQLOutput side will follow soon. :-)
Markus
--
Markus Schaber | Logical Tracking&Tracing International AG
Dipl. Inf. | Software Development GIS
Fight against software patents in Europe! www.ffii.org
www.nosoftwarepatents.org
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SQLInput.diff
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/96f99770/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 252 bytes
Desc: OpenPGP digital signature
URL: <http://lists.pgfoundry.org/pipermail/pljava-dev/attachments/20060922/96f99770/attachment.bin>
From | Date | Subject | |
---|---|---|---|
Next Message | Markus Schaber | 2006-09-22 16:07:45 | [Pljava-dev] Patch for SQLOutput implementation |
Previous Message | Thomas Hallgren | 2006-09-22 15:25:18 | [Pljava-dev] readBytes() / writeBytes() |