Re: More new SQL/JSON item methods

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: More new SQL/JSON item methods
Date: 2024-01-25 20:58:20
Message-ID: 451195.1706216300@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> There's something else going on, because I'm still getting the
> assertion failure on my Mac with this fix in place. Annoyingly,
> it goes away if I compile with -O0, so it's kind of hard to
> identify what's going wrong.

No, belay that: I must've got confused about which version I was
testing. It's very unclear to me why the undefined reference
causes the preceding Assert to misbehave, but that is clearly
what's happening. Compiler bug maybe? My Mac has clang 15.0.0,
and the unhappy buildfarm members are also late-model clang.

Anyway, I did note that the preceding line

res = jperOk;

is dead code and might as well get removed while you're at it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2024-01-25 20:59:22 [Doc] Improvements to ddl.sgl Privileges Section and Glossary
Previous Message Dave Cramer 2024-01-25 20:56:20 Re: [PATCH] Add native windows on arm64 support