| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: guc comment changes (was Re: Getting a move on for 8.2 |
| Date: | 2006-09-20 12:56:23 |
| Message-ID: | 45113A77.5040100@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> That does not mean that the patch is bad, and I certainly support the
>> feature change. But I can't efficiently review the patch. If someone
>> else wants to do it, go ahead.
>
> I've finally taken a close look at this patch, and I don't like it any
> more than Peter does. The refactoring might or might not be good at its
> core, but as presented it is horrid. As just one example, it replaces one
> reasonably well-commented function with three misnamed, poorly commented
> functions. In place of
Thanks Tom for your time to look on the code and for your feedback. It
is very useful for me.
Thanks Zdenek
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gevik Babakhani | 2006-09-20 13:01:41 | Re: Opinion wanted on UUID/GUID datatype output formats. |
| Previous Message | Tom Dunstan | 2006-09-20 12:56:08 | Re: Opinion wanted on UUID/GUID datatype output formats. |