From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Variadic aggregates vs. project policy |
Date: | 2013-08-30 13:13:51 |
Message-ID: | 4510.1377868431@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> writes:
> I was one who sent a bug report - this error is not too dangerous, but it
> is hidden, and difficult to find, if you don't know what can be happen.
> Same as bug with plpgsql and SQL identifier collisions. If you understand,
> then you can protect self well and simply. If not, then it is a magic
> error. So still I am thing so best solution is
> a) a warning when detect ORDER BY in variadic aggregates
Such a warning would never be tolerated by users, because it would appear
even when the query is perfectly correct.
> b) disallow ORDER BY in variadic aggregates in classic syntax, and enable
> it only in WITHIN GROUP syntax where is safe ,
And we're *not* inventing randomly different syntax for variadic
aggregates. That ship sailed when we did it this way for regular
functions.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2013-08-30 13:18:02 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |
Previous Message | Andres Freund | 2013-08-30 13:06:27 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |